Saggi Mizrahi has posted comments on this change.
Change subject: [WIP] Replace 'cp' and 'mkdir' with $(INSTALL)
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
Good job, this will help make us look a bit more presentable
....................................................
File vdsm.spec.in
Line 70: install -dDm 1777 "%{buildroot}"%{_localstatedir}/log/core
why not just have /var/log/vdsm/core writable by vdsm?
Line 282: %{_sysconfdir}/sudoers.d/50_vdsm
this changes the permission on the resulting file. Should we care?
--
To view, visit
http://gerrit.usersys.redhat.com/703
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5e6215c30a3feb80e60e4feaff1d5280f7d1d08
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>