From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: hugepages: add support for shared pages ......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/77808/2/vdsm/virt/vm.py File vdsm/virt/vm.py:
PS2, Line 420: conv.tobool
We should not use this evil tobool, if the input is not a bool, we should e
the value of custom properties is always a string, Engine can never send a bool. Maybe you suggest that we are stricter here
if custom.get('hugepages_shared') == 'True': hugepages_shared = True elif ('False', None) hugepages_hsared = False else: raise ValueError
I find this pile of code a bit ugly, and don't mind being a bit more flexible when it comes to human-typed values.