On Sun, Oct 02, 2011 at 09:55:47AM +0200, Dan Kenigsberg wrote:
On Sun, Oct 02, 2011 at 02:00:04AM -0400, Igor Lvovsky wrote:
Well done Adam. ACK,
Dan, this patch also solve our: Bug 735621 - getStorageDomainInfo for local domains doesn't return 'remote path ' So, maybe we need mention it in the commit message
Speaking about commit message, the following part of the message should be dropped. I think we agreed that the path is a critical piece of information that should be reported, but should not be recorded in the domain metadata.
In the code I have noticed some sentiments that path information should be removed from the storage domain metadata. I strongly disagree with this idea. The path is a critical piece of information. End users will care a lot about the path because it is where their images are located. This informaton is also useful for calling connectStorageServer() and disconnectStorageServer().
Fine by you, Adam?
Yes, agreed.