Dan Kenigsberg has posted comments on this change.
Change subject: Packaging: Fix misleading help string for --enable-libvirt-sanlock
......................................................................
Patch Set 1:
(1 comment)
....................................................
File configure.ac
Line 54:
Line 55: AC_ARG_ENABLE(
Line 56: [libvirt-sanlock],
Line 57: [AS_HELP_STRING([--enable-libvirt-sanlock],
Line 58: [enable libvirt sanlock plugin
@<:@default=yes@:>@])],
How about changing the help text to
[default=enabled]
?
Line 59: ,
Line 60: [enable_libvirt_sanlock="yes"]
Line 61: )
Line 62: AC_SUBST([ENABLE_LIBVIRT_SANLOCK], ["${enable_libvirt_sanlock}"])
--
To view, visit
http://gerrit.ovirt.org/19005
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes