Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsm/storage/hsm.py PEP8 clean
......................................................................
Patch Set 4: No score
(1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 798: "poolName=%s, masterDom=%s, domList=%s, masterVersion=%s,
"
Line 799: "safelease params: (%s)" % (
Line 800: spUUID, poolName, masterDom, domList,
Line 801: masterVersion, safeLease
Line 802: )
I can accept both style. The latter is more compact.
Line 803: )
Line 804: )
Line 805: misc.validateUUID(spUUID, 'spUUID')
Line 806: if masterDom not in domList:
--
To view, visit
http://gerrit.ovirt.org/4530
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9b2f8b9e83db6f52678b4e0865668a79bcf53f5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server