Zhou Zheng Sheng has posted comments on this change.
Change subject: clean PEP 8 problems in vdsm/clientIF.py ......................................................................
Patch Set 1: (3 inline comments)
.................................................... File vdsm/clientIF.py Line 76: ifrates=ifrates) Thanks for the advise. I follow the instruction on indentation in PEP 8 (http://www.python.org/dev/peps/pep-0008/#indentation). It says Continuation lines should align wrapped elements.
So I can do:
self._hostStats = utils.HostStatsThread(cif=self, log=log, ifids=ifids, ifrates=ifrates)
or
self._hostStats = utils.HostStatsThread( cif=self, log=log, ifids=ifids, ifrates=ifrates)
Line 244: 'vmPayload' in drive['specParams']): If I put it into one line, it would occupy 81 characters.
Line 408: continue Well I think it can be changed into:
if f in ('vdsmd.pid', 'respawn.pid', 'svdsm.pid', 'svdsm.sock'): continue
-- To view, visit http://gerrit.ovirt.org/4802 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0f912dd53f84b57f09665edb80c99768006e725c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com