From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: vmdevices: add methods to access the config ......................................................................
Patch Set 9: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/77816/9//COMMIT_MSG Commit Message:
Line 6: Line 7: virt: vmdevices: add methods to access the config Line 8: Line 9: To support the path preparation, we need to pass through the storage Line 10: state in vm.conf format. When Engine requests VMs via vm.conf, the conf-based definition of storage devices is used by the likes of _preparePathsForDrives() to prepare the storage and call the hooks.
When Engine requests VMs via domxml, we need to generate the conf-based definition, so it can be used by the same implementing function. Line 11: Add methods to extract the device object state in the vm.conf format, Line 12: and to update it in bulk. Line 13: Line 14: Change-Id: I7876051edd45b1dd922ce236de77867e0584c07d