Federico Simoncelli has posted comments on this change.
Change subject: Check the metadata on domain validation ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/storage/blockSD.py Line 725: if not len(self.getMetadata()): We could actually try to push this validation inside the metadata providers (raise if the metadata is missing/empty). In such case we must check all the flows since there might be a situation where we rely on the empty metadata (eg: when we select the meta provider for the block domains, etc...).
-- To view, visit http://gerrit.ovirt.org/7085 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I35071b85da2689cd576e9fd0d97cc374db26bf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com