Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit ......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/8/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py:
Line 193: else: Line 194: # We don't want to empty the volume as a result of the commit Line 195: # operation. To do so, we provide the '-d' option when the base Line 196: # isn't provided. When the base volume is provided, the top volume Line 197: # will not be emptied after the commit operation. Can we shorten this to one line? Line 198: # This is important mainly when we want to wipe the volume before Line 199: # deleting it. Emptying it may leave the data on the underlying Line 200: # storage. Line 201: cmd.append("-d")