Hello Nir Soffer, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: tool: Use space after comma when formatting lists ......................................................................
tool: Use space after comma when formatting lists
When formating list of modules in error message, we used to do:
foo,bar,baz
Now lists are formatted in more readable way:
foo, bar, baz
Change-Id: I88d742b72ba57ad1de481a589ca53e71c8202176 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: http://gerrit.ovirt.org/31784 Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/tool/configurator.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/32058/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 268ae46..12cc0af 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -101,7 +101,7 @@
if m: sys.stdout.write( - "Modules %s are not configured\n " % ','.join(m), + "Modules %s are not configured\n " % ', '.join(m), ) ret = False
@@ -135,7 +135,7 @@
if m: sys.stdout.write( - "Modules %s contains invalid configuration\n " % ','.join(m), + "Modules %s contains invalid configuration\n " % ', '.join(m), ) ret = False