Dan Kenigsberg has posted comments on this change.
Change subject: net: Link setup module - includes bond setup logic.
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/62831/8/lib/vdsm/network/link/setup.py
File lib/vdsm/network/link/setup.py:
Line 36: def remove_bonds(self):
Line 37: for bond_name in self._bonds2remove:
Line 38: Bond(bond_name).destroy()
Line 39:
Line 40: def edit_bonds(self):
this method begs to have its own unit test
Line 41: for bond_name, attrs in six.iteritems(self._bonds2edit):
Line 42: bond = Bond(bond_name)
Line 43:
Line 44: requested_slaves = set(attrs['nics'])
--
To view, visit
https://gerrit.ovirt.org/62831
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes