Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fixing pep8 in vdsm/define.py ......................................................................
Patch Set 2: (2 inline comments)
Mostly good, but I'd like someone else's opinion regarding changing the message before giving +1.
.................................................... File vdsm/define.py Line 44: 'message': 'Error creating the requested VM'}}, Not sure what to think of changing the message for line length in the code.
Line 61: 'Not enough free memory to create VM'}}, Same
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com