Dan Kenigsberg has posted comments on this change.
Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/configNetwork.py Line 370: cf = self.NET_CONF_PREF + name Line 371: cfg = """DEVICE=%s\nONBOOT=%s\n""" % (pipes.quote(name), Line 372: pipes.quote(onboot)) Line 373: cfg += conf Line 374: # Check whether we need to preserve prev ip/mask/gateway I do not see my main issue related by this version... Line 375: if not ipaddr and os.path.exists(cf): Line 376: ipaddr = self._getConfigValue(cf, 'IPADDR') Line 377: netmask = self._getConfigValue(cf, 'NETMASK') Line 378: gateway = self._getConfigValue(cf, 'GATEWAY')
-- To view, visit http://gerrit.ovirt.org/7259 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a6481c64c285b8a9bd6f6cc49c1c84507c91603 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server