Dan Kenigsberg has posted comments on this change.
Change subject: Handling svdsm exception in multipath opeartion ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... Commit Message Line 9: without handling the exception, the exception is raised to hsm __init__ Line 10: and cause failure in initialization. afterwards, vdsm is not Line 11: operational for hsm operations. Line 12: Line 13: This patch consider svdsm failure as an error in operation without why do we want to keep on working when svdsm is throwing exception? it is quite an important piece of vdsm; I'd rather bail out if it cannot start. Line 14: paralyzed vdsm. Line 15: Line 16: Change-Id: Id56ab966f3a21f4ef9fac0ad05e4f00f25cc16b3 Line 17: Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=890365
.................................................... File vdsm/storage/multipath.py Line 90: svdsm = supervdsm.getProxy() Line 91: mpathconf = svdsm.readMultipathConf() Line 92: # we don't handle specific exception types here because any exception Line 93: # means that the operation failed and we can't destinguish if multipath Line 94: # is enabled or not if we cannot distinguish between True and False, why are you returning False? raising an exception is just for such cases. Line 95: except: Line 96: log.error("failure in reading multipath conf", exc_info=True) Line 97: return False Line 98:
-- To view, visit http://gerrit.ovirt.org/10508 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id56ab966f3a21f4ef9fac0ad05e4f00f25cc16b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server