Timothy Asir has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data alignment ......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/47959/2//COMMIT_MSG Commit Message:
Line 6: Line 7: gluster: fix brick devices are created with incorrect data alignment Line 8: Line 9: Removed make partition function and pv create will not create Line 10: any partition on the given device.
If there is no partition on the disk, how do we know a disk has filesystem
Yes, blivet provides such information,
disk.format.type is not None, will tells us the disk has some kind of data on it.
Also, disk.format.type is not None and not disk.partitioned the first one is True only if the disk contains an actual filesystem (not swap, lvm pv) the second is True if the disk contains a filesystem, swap, lvm pv, luks, &c Line 11: Line 12: Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968 Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1270792