Dan Kenigsberg has posted comments on this change.
Change subject: Fix lock release and reversed SPM logic. ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/sp.py Line 431: else: Line 432: cls.log.debug("master `%s` is not mounted, skipping", master) Line 433: Line 434: def stopSpm(self, force=False): Line 435: self.lock.acquire() 'with' is prettier. Line 436: try: Line 437: if not force and self.getSpmRole() and SPM_FREE: Line 438: return True Line 439:
-- To view, visit http://gerrit.usersys.redhat.com/1066 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3e2335163e45dc601d6779b45beb03d67e997692 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo Warszawski ewarszaw@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com