Saggi Mizrahi has posted comments on this change.
Change subject: getAllVolumes() unit test. ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
I also don't like the extraneous files. Just put the strings in the python file.
.................................................... File tests/getAllVolumesTests.py Line 50: storage.blockSD.lvm.getLV = self.mGetLV You need to remember to revert the monkey patch or other tests might malefunction
Line 68: inp = open(os.path.join(sdHead, "glob_%s.out" % sdName), "r").read() Don't trust refcount to close your files
Line 69: # Danger Will Robinson! Danger! I cannot accept this course of action
Line 73: return True I don't think this passes pep8
-- To view, visit http://gerrit.ovirt.org/4592 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic7cfb77f7675a58858507acf2b708317eb30a43d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com