Bala.FA has posted comments on this change.
Change subject: tests: Fix parted_utils_tests break on fedora 18 ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File tests/parted_utils_tests.py Line 43: Line 44: # parted 3.1 improves its support for loopback devices. The 'model' string Line 45: # returned by libparted is updated to 'Loopback device' Line 46: ts = rpm.TransactionSet() Line 47: parted_version = float(list(ts.dbMatch('name', 'parted'))[0]['version']) Please use parted.version() than getting from rpmdb. Line 48: if parted_version >= 3.1: Line 49: LOOP_DEVICE_MODEL = 'Loopback device' Line 50: else: Line 51: LOOP_DEVICE_MODEL = ''
-- To view, visit http://gerrit.ovirt.org/10843 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1accc7eb6fc6c64b5e27fb27d9e675ad523725b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server