Zhou Zheng Sheng has posted comments on this change.
Change subject: fix crash when sync with libvirt network ......................................................................
Patch Set 2:
Before Igor Lvovsky's commit b60650fc, vdsmd will backup when sync with libvirt network, so writeBackupFile function is called by vdsmd indirectly, then it will trigger a permission error. So I let it chown to vdsm:kvm to avoid that error.
After discussion with Royce Lv, we discovered that neither this patch nor commit b60650fc is elegant.
This patch chown to vdsm:kvm to avoid the permission problem, and commit b60650fc skip the backup by adding a not-so-nice bool parameter to the createLibvirtNetwork function.
Since Dan said the writeBackupFile function is supposed to called only by superVdsm, when vdsmd sync with libvirt network, the clientIF._syncLibvirtNetworks function should be delegated to superVdsm, then there will be no permission problems. In general, sync network config may need root privilege in various situations, do delegate it to superVdsm is more appropriate.
-- To view, visit http://gerrit.ovirt.org/7156 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4a3ea0303656cba87bf17b14929fe59bf0d46337 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server