Shu Ming has posted comments on this change.
Change subject: During disabling ssl in vdsm we should change config in libvirtd and qemu. ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/vdsmd.init.in Line 127: echo "qemu.conf: spice_tls=0." I am confused here. Is "spice_tls" not a option in qemu.conf only? So "spice_tls=0" should not in libvirtd.conf. The third line should be like
echo "libvirtd.conf: listen_tcp=1, auth_tcp="none""
-- To view, visit http://gerrit.ovirt.org/7108 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I899e37c3218668f3d8c0603ca0276dedbb6cb8fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yair Zaslavsky yzaslavs@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server