Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd.init: remove validation to reload config ......................................................................
Patch Set 1: I would prefer that you didn't submit this
Does this solve a real problem? I think that in oVirt node, there is never a new version of libvirt that is introduced, so we never need to reload-configuration.
`initctl reload-configuratoin` is not something that normal sysV services do, so it carries a surprise factor I would like to avoid.
Maybe a clearer code would be to avoid this code section of ovirt node (assuming there is no functional problem fixed by this patch)
Sorry I did not see this issue in a private correspondece we had earlier.
-- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com