Dan Kenigsberg has posted comments on this change.
Change subject: Removing has_systemd from sysv script
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
Commit Message
Line 5: CommitDate: 2013-09-03 12:11:11 +0300
Line 6:
Line 7: Removing has_systemd from sysv script
Line 8:
Line 9: After separating sysv and systemd common code, there is no need for
commit message is misleading. it is NOT a cleanup patch.
there's a serious bug here: the has_systemd function definition has been dropped, but
the script is still using it. This should be stated.
Line 10: has_systemd parts in sysv init script, as it doesn't in use at all over
Line 11: systemd.
Line 12:
Line 13: Change-Id: Ief9be5503c84e2cf960e722e5097dbdc05b888a6
--
To view, visit
http://gerrit.ovirt.org/18806
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9be5503c84e2cf960e722e5097dbdc05b888a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes