Mark Wu has posted comments on this change.
Change subject: Fix inefficiency in getBridgelessNetworks ......................................................................
Patch Set 1: (1 inline comment)
It looks good to me except the function's docstring.
.................................................... File vdsm/netinfo.py Line 444: Get list of bridgeless networks Line 445: Line 446: :returns: list of network names Line 447: :rtype: List Line 448: """ The docstring should be updated accordingly. Line 449: for network, netdict in self.networks.iteritems(): Line 450: if not netdict['bridged']: Line 451: yield network Line 452:
-- To view, visit http://gerrit.ovirt.org/11071 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68b5ecf415d4ab49a56019d8875dde57ca29d1fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server