Eduardo has posted comments on this change.
Change subject: Added an option to create a balloon device on VM creation. ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
A virtual memory balloon device is added to all Xen and KVM/QEMU guests. It will be automatically added when appropriate, so there is no need to explicitly add this element in the guest XML unless a specific PCI slot needs to be assigned or the device should be disabled.
Please do the right thing.
.................................................... Commit Message Line 7: Added an option to create a balloon device on VM creation. A virtual memory balloon device is added to all Xen and KVM/QEMU guests. Therefore this patch adds the disable cap.
.................................................... File vdsm/libvirtvm.py Line 724: def _appendBalloon(self): Since the balloon is a device should be a class as the other devices: disk and network. Should support addresses, which is in libvirt capabilities, and have a getXml method.
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com