Federico Simoncelli has posted comments on this change.
Change subject: blockSD: do not try to parse metadata from missing pv ......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/27442/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py:
Line 670: pv = lvm.getPV(dev) Line 671: if not pv: Line 672: cls.log.warning("Could not get metadata from the device: %s", Line 673: dev) Line 674: continue
This is not incomplete mapping - this is the complete list of pv available
You get the list of pvs and then you iterate over them to get the info. It doesn't mean that the info becomes irrelevant if something changes between the listing and the retrieval. Line 675: pvInfo = {} Line 676: pvInfo["guid"] = os.path.basename(pv.name) Line 677: pvInfo["uuid"] = pv.uuid Line 678: # this is another trick, it's not the