Federico Simoncelli has posted comments on this change.
Change subject: vm: Set disk replica only if it can be prepared
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40022/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3021: # The device entry is enforced because stricly required by
Line 3022: # prepareVolumePath
Line 3023: dstDiskCopy['device'] = srcDrive.device
Line 3024:
Line 3025: dstDiskCopy['path'] = self.cif.prepareVolumePath(dstDiskCopy)
You have to _setDiskReplica first and then prepare otherwise there's no track of the
volume being prepared if we crash in the middle.
Line 3026: try:
Line 3027: self._setDiskReplica(srcDrive, dstDisk)
Line 3028:
Line 3029: try:
--
To view, visit
https://gerrit.ovirt.org/40022
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43814fa41c9cdc830fee9e929baa2e8249b18720
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes