Maor Lipchuk has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/64373/6/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:
Line 137:
Line 138: @property
Line 139: def qcow2_compat(self):
Line 140: dom = sdCache.produce_manifest(self.sd_id)
Line 141: return dom.qcow2_compat()
Nice!
I saw that we don't have any where in
storage_sdm_copy_data_test tests for properties.
Also what can we test here? it is simply an API to fetch a domain and get its
qcow2_compat
Line 142:
Line 143: @property
Line 144: def backing_qemu_format(self):
Line 145: parent_vol = self._vol.getParentVolume()
--
To view, visit
https://gerrit.ovirt.org/64373
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26e5dcba6fc493b32ea7764889df2918c4dfdd3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes