Dan Kenigsberg has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm.spec.in Line 527: Line 528: %post hook-faqemu Line 529: cat /proc/cpuinfo | grep -q "vmx | svm" Line 530: vt_supported=$? Line 531: if [ $vt_supported -ne 0 ]; then frankly, I do not like editing our own configuration scripts... Would you agree to limit this editing to cases where a human did not have something else in vdsm.conf ?
I mean - if someone explicitly wrote
fake_kvm_support=False
we should not override that. Line 532: /usr/share/vdsm/set-conf-item /etc/vdsm/vdsm.conf vars fake_kvm_support true Line 533: fi Line 534: Line 535: %files
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server