Dan Kenigsberg has posted comments on this change.
Change subject: Move vdsmd.init to vdsm-tool
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm-tool/vdsmd.py
Line 133: def _print_success_msg(msg):
I do not see the great importance of keeping the [SUCCESS] output of `success`. If you
think you need to report success, use `print`. Note that currently systemd swallows that
and puts it in /var/log/messages.
Line 596: @vdsm_tool_expose('vdsm-start')
Please expose smaller, atomic, functions.
In particular, I know that many people find 'reconfigure' as useful.
--
To view, visit
http://gerrit.ovirt.org/4738
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52db67207532ac7ded51cdd8c5dc388e85629104
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>