Federico Simoncelli has posted comments on this change.
Change subject: udev: Race fix- load and trigger dev rule(#891300) ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/storage/hsm.py Line 2927: supervdsm.getProxy().udevReloadRules(guid) Line 2928: supervdsm.getProxy().udevTrigger(guid) Line 2929: supervdsm.getProxy().udevSettle(guid) Line 2930: try: Line 2931: devPath = '/dev/mapper/%s' % guid I don't like this embedded here but I guess we'll fix this in the future. Line 2932: fileUtils.validateQemuReadable(devPath) Line 2933: except OSError: Line 2934: self.log.error("Failed to appropriate device permission") Line 2935: raise
-- To view, visit http://gerrit.ovirt.org/10758 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If3b2008a3d9df2dcaf54190721c2dd9764338627 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvolansk@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server