Dan Kenigsberg has posted comments on this change.
Change subject: BZ#845994 VM failed to start after file injection. ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
there's still a big place for improvement, but I like the direction. thanks.
BTW, any idea how this code passed the automated build? I get
./vdsm_hooks/fileinject/before_vm_start.py:8: 'tempfile' imported but unused
.................................................... File vdsm_hooks/fileinject/before_vm_start.py Line 4: import sys Line 5: import hooking Line 6: import traceback Line 7: import guestfs Line 8: import tempfile thanks for dropping its usage, now please drop the import of tempfile. Line 9: Line 10: ''' Line 11: fileinject vdsm hook Line 12: ====================
Line 23: syntax: Line 24: fileinject=/<target file name> : <file content> Line 25: fileinject=/myfile:some file content\netc... Line 26: ''' Line 27: pep8 WANTED the newline that you've deleted. Line 28: def inject_file(filepath, content, drive, diskformat): Line 29: injected = False Line 30: gfs = guestfs.GuestFS() Line 31: try:
-- To view, visit http://gerrit.ovirt.org/6956 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibb705a7153b1d2662a1c113bbbb5c694c568cabd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com