Ayal Baron has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 5: Looks good to me, approved
(1 inline comment)
.................................................... File vdsm/storage/volume.py Line 450: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): I don't like the placement of this logic but with the current design I find it hard to think of anything better.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com