Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock
......................................................................
Patch Set 4:
(1 comment)
....................................................
File configure.ac
Line 47
Line 48
Line 49
Line 50
Line 51
Hi.
Currently the help string is "--disable-xxx disable xxx [default=yes]". This
is confusing, implies that "--disable-xxx" can accept a value and the value is
"yes" by default: "--disable-xxx=yes". This is because by convention
"[default=yes]" is for the argument value given to the option. The first time I
saw this help string I thought you suggests "--disable-xxx=yes|no". However
actually "--disable-xxx" does not accept any value, so we should remove
"[default=yes]" from all "--disable-xxx" help string.
We all know the default of sanlock plugin is enabled. By keeping "[default=yes]"
with "--disable-libvirt-sanlock", you are actually explaining the default value
of "--enable-libvirt-sanlock" but not "--disable-libvirt-sanlock". So
either remove the "[default=yes]" from "--disable-xxx" help string,
or change it to "--enable-xxx blah [default=yes]".
"[default=value]" is valid for "--enable-xxx" options, so we should
keep them.
In all, from the official manual and the example packages I examined, the following three
forms are correct.
--enable-xxx help string
--enable-xxx[=value] help string [default=blah]
--disable-xxx help string
and this is exactly what this patch is about.
As for the with-xxx and without-xxx, they are similar. "./configure
--with-xxx=yes|no" is valid and "./configure --without-xxx=yes|no" gives
you an error.
--
To view, visit
http://gerrit.ovirt.org/19005
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes