Dan Kenigsberg has posted comments on this change.
Change subject: udev: Race fix- load and trigger dev rule ......................................................................
Patch Set 8: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/supervdsmServer.py Line 236: '--property-match=DM_NAME=%s' % guid] Line 237: rc, out, err = misc.execCmd(cmd, sudo=False) Line 238: if rc: Line 239: self.log.error("Udevadm trigger command failed rc=%s, \ Line 240: out="%s", err="%s"", rc, out, err) underindent would fail pep8 on f18. (here and elsewhere) Line 241: raise OSError(errno.EINVAL, "Could not trigger change for device \ Line 242: %s" % guid) Line 243: Line 244: @logDecorator
Line 317: reload = '--reload' if __udevOperationReload() else '--reload-rules' Line 318: cmd = [EXT_UDEVADM, 'control', reload] Line 319: rc, out, err = misc.execCmd(cmd, sudo=False) Line 320: if rc: Line 321: self.log.error("Udevadm reload-rules command failed rc=%s, \ too many spaces in string (try it out and see).
better break line with
( "Udevadm reload-rules command failed rc=%s, " "out="%s", err="%s"" )
and use single quotes to avoid annoying escaping. Line 322: out="%s", err="%s"", rc, out, err) Line 323: raise OSError(errno.EINVAL, "Could not reload-rules for device \ Line 324: %s" % guid) Line 325:
-- To view, visit http://gerrit.ovirt.org/10758 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If3b2008a3d9df2dcaf54190721c2dd9764338627 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvolansk@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Vered Volansky vvolansk@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server