Vinzenz Feenstra has posted comments on this change.
Change subject: drop ominous log for libvirt errors ......................................................................
Patch Set 1:
If we wouldn't swallow so many exceptions all over the place, I wouldn't have a problem with that. But vdsm is full of except/pass lines where we would never know if anything like this was reported. This is now a debug message and it is harmless in comparison the amount of messages which come from storage for example.
There were moments which would have made our lives enormously easier with having this log line. Especially when libvirt is changing/adding error codes. In those cases it's pretty hard to understand why something that used to work does not work any longer and this is the reason why we put this log in place. I honestly do not understand the aversion of this. There's probably much more less useful stuff logged in vdsm and this is the item I am insisting to keep it.
And it doesn't matter if in the past 11 months there was no such instance happening again. My prime reason is the commit I introduced this for. Look how long it took to realize what the problem is in the bug related to that original commit: https://bugzilla.redhat.com/show_bug.cgi?id=852956
It's more than half a year before we figured out what was the real deal. If we would have had the codes somewhere logged we could have seen some potential difference. Especially the difference between the libvirt version on Fedora and on RHEL. They are quite far apart even if features get backported.