Dan Kenigsberg has submitted this change and it was merged.
Change subject: Unify produceVolume ......................................................................
Unify produceVolume
Unify produceVolume function and make it use getVolumeClass so that subclasses can override getVolumeClass to specify their own Volume and ensure that produceVolume works properly with subclass supplying their own volumeclass.
Change-Id: I367582b2741dc0276ec64d8d13fa1e4953f0314b Signed-off-by: Deepak C Shetty deepakcs@linux.vnet.ibm.com --- M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py M vdsm/storage/sd.py 3 files changed, 7 insertions(+), 14 deletions(-)
Approvals: Dan Kenigsberg: Looks good to me, approved Deepak C Shetty: Verified
-- To view, visit http://gerrit.ovirt.org/8115 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I367582b2741dc0276ec64d8d13fa1e4953f0314b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server