Bala.FA has posted comments on this change.
Change subject: gluster: Add gluster volume geo-replication configuration feature ......................................................................
Patch Set 1:
(1 comment)
.................................................... File vdsm/gluster/cli.py Line 159: 'working_dir': ( Line 160: 'workingDir', Line 161: 'working directory', Line 162: GeoRepConf.READONLY)} Line 163: As this is very similar to volume set help xml, I would prefer 1) file a bug in glusterfs for geo-rep set help xml for this.
2) till the bug get fixed, have the expected xml in a file and load it at the time of module load and have a clear comment about this is temporarily
3) Use the xml object wherever applicable Line 164: Line 165: def _execGluster(cmd): Line 166: return utils.execCmd(cmd) Line 167: