Maor Lipchuk has posted comments on this change.
Change subject: vm: Add qcow2_compat on create ......................................................................
Patch Set 20:
(2 comments)
https://gerrit.ovirt.org/#/c/64377/20/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 2698: transientHandle, transientPath = tempfile.mkstemp( Line 2699: dir=config.get('vars', 'transient_disks_repository'), Line 2700: prefix="%s-%s." % (diskParams['domainID'], diskParams['volumeID'])) Line 2701: Line 2702: sdDom = sdc.sdCache.produce_manifest(sdUUID=diskParams['domainID'])
procude_manifest accepts one positional argument, calling it using kwargs s
Done Line 2703: try: Line 2704: qemuimg.create(transientPath, Line 2705: format=qemuimg.FORMAT.QCOW2, Line 2706: backing=diskParams['path'],
Line 2703: try: Line 2704: qemuimg.create(transientPath, Line 2705: format=qemuimg.FORMAT.QCOW2, Line 2706: backing=diskParams['path'], Line 2707: qcow2Compat=sdDom.qcow2_compat(),
This is the compat of the image, not the backing file. Please use the same
Done Line 2708: backingFormat=driveFormat) Line 2709: os.fchmod(transientHandle, 0o660) Line 2710: except Exception: Line 2711: os.unlink(transientPath) # Closing after deletion is correct