Dan Kenigsberg has posted comments on this change.
Change subject: Avoid re-setting <boot> element when updating nic properties
......................................................................
Patch Set 1: Code-Review-1
You are right. libvirt-0.10.2-18.el6_4.9.x86_64 is unnerved by the fact that we do not
pass the <boot> element. updateDevice still explodes.
2013-09-03 13:32:37.183+0000: 2349: debug : virDomainUpdateDeviceFlags:9825 :
dom=0x7f9094083830, (VM: name=psebek-vm1, uuid=51493dc4-72f8-4aa0-89a2-dde934d5d618),
xml=<interface type="bridge"><address bus="0x00"
domain="0x0000" function="0x0" slot="0x03"
type="pci"/><mac address="00:1a:4a:09:65:18"/><model
type="virtio"/><source bridge="rhevm"/><filterref
filter="vdsm-no-mac-spoofing"/><link
state="down"/></interface>, flags=1
2013-09-03 13:32:37.183+0000: 2349: debug : qemuDomainObjBeginJobInternal:808 : Starting
job: modify (async=none)
2013-09-03 13:32:37.183+0000: 2349: error : qemuDomainChangeNet:1487 : this function is
not supported by the connection driver: cannot modify network device boot index setting
--
To view, visit
http://gerrit.ovirt.org/18796
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81e1476e3ed31c9b07738cad1e45887f858d842
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No