Eduardo has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 6: (1 inline comment)
.................................................... File vdsm/storage/volume.py Line 450: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): There are _real_performance hits due the fact the metadata is accessed most of the times. In addition the same metadata is read many times in a row by the same thread. But this is no the reason. This is adding another reversed dependency like image -> volume -> SD and we need to remove this since is more correct to do it at the SD level. This change make this more difficult to reach. A bool parameter, is not nice, but is not a so "complicated" interface.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com