Francesco Romani has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
......................................................................
Patch Set 37:
This patch can actually run against an old libvirt, since all the communication involved happens through XML; In that scenario, of course the feature won't work and any setting will be silently ignored.
For VDSM there is no problem then, but engine cannot expose a feature which won't work. I guess we can report this by piggybacking on ABORT_ON_IO_ERROR but this is quite ugly :(
--
To view, visit
http://gerrit.ovirt.org/26917
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4
Gerrit-PatchSet: 37
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Frank Kobzik
fkobzik@redhat.com
Gerrit-Reviewer: Martin Polednik
mpoledni@redhat.com
Gerrit-Reviewer: Michal Skrivanek
michal.skrivanek@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra
vfeenstr@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No