Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Move vdsmd.init to vdsm-tool
......................................................................
Patch Set 4: (6 inline comments)
....................................................
File vdsm/constants.py.in
Line 142: EXT_TC = '@TC_PATH@'
@Adam: He moved it here.
....................................................
File vdsm-tool/vdsmd.py
Line 211: except:
Maybe we could catch a specific exception here. KeyError or something?
Line 215: def _is_ovirt():
This looks like a copy of isOvirt in vdsm_reg/deployUtil.py. Maybe we could place this in
some common place?
Line 232: return False
I'd prefer:
return _get_config_item(...) == 'true'
Line 366: return False
Again, great fan of a single return:
return bonddev in bond
Line 427: return 6
I think this could be a constant as well.
--
To view, visit
http://gerrit.ovirt.org/4738
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52db67207532ac7ded51cdd8c5dc388e85629104
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>