Federico Simoncelli has posted comments on this change.
Change subject: Use cp to copy sparse volumes when moving a vm ......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/image.py Line 583: # Do the actual copy Line 584: try: Line 585: dstVol = destDom.produceVolume(imgUUID=imgUUID, volUUID=srcVol.volUUID) Line 586: # Copy sparse files with cp. Line 587: if isinstance(dstVol, fileVolume.FileVolume): This looks like it's something that should be implemented by the volume class (so for example other domain/volume types, as gluster, could define their own way to make the copy). Line 588: misc.cpWatchCopy(srcVol.getVolumePath(), Line 589: dstVol.getVolumePath(), Line 590: vars.task.aborting, sparse=True) Line 591: else:
-- To view, visit http://gerrit.ovirt.org/10543 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0c4c693884a225c868c18bdcb4930c2c1042db2c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dafna Ron dron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server