Federico Simoncelli has posted comments on this change.
Change subject: blockSD: raise an exception if missing physical volume ......................................................................
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/27442/7/vdsm/storage/lvm.py File vdsm/storage/lvm.py:
Line 824: def getPV(pv): Line 825: pv = _lvminfo.getPv(_fqpvname(pv)) Line 826: if not pv: Line 827: raise se.InaccessiblePhysDev(pv) Line 828: return pv In hsm.py we have:
try: pv = lvm.getPV(guid) except se.StorageException: self.log.warning("getPV failed for guid: %s", guid, exc_info=True) else: if pv is None: continue
I think it should be fixed (at least remove the "is None" check). Line 829: Line 830: Line 831: def getAllPVs(): Line 832: return _lvminfo.getAllPvs()