Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: return proper exit code from bootstrap scripts ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vds_bootstrap/setup Line 173: execfn += [random_num] Line 174: execfn.append(str(int(rebootAfterInstallation))) Line 175: logging.debug("trying to run %s script cmd = '%s'",script, string.join(execfn, " ")) Line 176: proc = subprocess.Popen(execfn) Line 177: proc.communicate() I think we discussed this... the stderr is redirected to our stderr and go to the engine to log. Line 178: if proc.returncode == 0: Line 179: return True Line 180: else: Line 181: logging.debug("script %s doen not exist",script)
-- To view, visit http://gerrit.ovirt.org/7301 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5cf1d2ad402641394da52099c157fc34cf49cad1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server