Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory ......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/2/vdsm/rpc/bindingjsonrpc.py File vdsm/rpc/bindingjsonrpc.py:
Line 24: Line 25: Line 26: # TODO test what should be the default values Line 27: _THREADS = config.getint('vars', 'worker_threads') Line 28: _TASK_PER_WORKER = config.getint('vars', 'tasks_per_worker')
Since you plan to an executor for xmlrpc, we can consider having [rpc] sect
Good idea. Line 29: _TASKS = _THREADS * _TASK_PER_WORKER Line 30: Line 31: Line 32: class BindingJsonRpc(object):