Igor Lvovsky has posted comments on this change.
Change subject: Unify the volume creation code in volume.create
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/storage/volume.py
Line 388: (volUUID, "volUUID", False), (srcImgUUID,
"srcImgUUID", True),
Ah, probably you are right we can't do it here.
_MERGE it's Edu's addition to the merge and I totally forgot about it.
what do you thing about moving this validation to the HSM level?
--
To view, visit
http://gerrit.ovirt.org/3627
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e44da32351a420f0536505985586b24ded81a2a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>