Nir Soffer has posted comments on this change.
Change subject: blockSD: raise an exception if missing physical volume ......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Suggested addition to the commit message that make make the benefit of the patch more clear.
http://gerrit.ovirt.org/#/c/27442/7//COMMIT_MSG Commit Message:
Line 16: This patch addresses these issues: Line 17: * The method _getDeviceList() in hsm.py already expects a StorageException Line 18: when getPV fails to read the physical volume. Line 19: * __processVGInfos in hsm.py and getMetadataMapping in blockSD.py don't Line 20: implement checks to assure the pv object returned by getPV is not None. ...so this patch replace a generic and confusing AttributeError (when trying to work with None) with relevant error that allows engine to display translated error message. Line 21: Line 22: Change-Id: I9932b044c8b439dc8b1f09191a5d89f4bc44c38a Line 23: Bug-Url: https://bugzilla.redhat.com/1048696