Igor Lvovsky has posted comments on this change.
Change subject: Added an option to create a balloon device on VM creation. ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 727: if self.conf.get('balloonEnabled', None): You can get this parameter as string from xmlRpc. So, the right thing to do is: if utils.tobool(self.conf.get('balloonEnabled', False)):
-- To view, visit http://gerrit.ovirt.org/1573 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com