Francesco Romani has posted comments on this change.
Change subject: vm: event: send status event on IO Error ......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/43312/6/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 3615: if not self.extendDrivesIfNeeded(): Line 3616: self.log.info("No VM drives were extended") Line 3617: Line 3618: # we need new disk stats Line 3619: self.send_status_event(**self._getRunningVmStats())
where/when do we need them?
good point(s). My reasoning was that after the resize, it is worth to send back immediately updated disk stats. But indeed need to check how much it takes. Line 3620: Line 3621: elif action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_REPORT: Line 3622: self.log.info('I/O error %s device %s reported to guest OS', Line 3623: err, blockDevAlias)